Feat CCT-965: Include timezone in the logs #3475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptoscano
requested changes
Nov 26, 2024
grunwmar
force-pushed
the
feat/965
branch
4 times, most recently
from
14adec7 to
d86505a
Compare
ptoscano
approved these changes
Nov 28, 2024
zpetrace
reviewed
Nov 29, 2024
ACK, thanks. I'll merge this one (which is good), and deal with the C bits for rhsmcertd.log in a separate PR. |
In `subscription-manager/src/rhsm/logutil.py`i: * New loggin formater class `RhsmISO8601Formatter` was made to ensure that time stamp entry is in ISO-8810 format and that it contains info about milliseconds and time zone. CARD CCT-965
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
subscription-manager/src/rhsm/logutil.py:New loggin formatter class
RhsmISO8601Formatteris made to ensure that time stamp entry is in ISO-8810 format and that it contains info about milliseconds and time zone.Then variable
LOG_FORMATTERis made andRhsmISO8601Formatter(LOG_FORMAT)is assigned to it. Then distributed to places where.setFormatter(Formatter(LOG_FORMAT, ...))occured.CARD CCT-965